Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine ClientUriBuilder #5148

Merged
merged 9 commits into from
Nov 22, 2024
Merged

Conversation

live1206
Copy link
Contributor

@live1206 live1206 commented Nov 19, 2024

  • Remove BaseType from ClientUriBuilder
  • Add UriBuilderType to HttpRequestApi
  • Make Instance(CSharpType type, params ValueExpression[] arguments) equivalent to New.Instance<T>(params ValueExpression[] arguments)
  • Apply the actual type of value during implementation of Declare(string name, ScopedApi value, out ScopedApi variable)
  • Replace RequestOptions with IHttpRequestOptionsApi

The corresponding changes in Azure plugin: Azure/azure-sdk-for-net#47259

@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Nov 19, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Nov 19, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Generator.CSharp.ClientModel
Microsoft.Generator.CSharp

@live1206 live1206 marked this pull request as ready for review November 20, 2024 01:24
Copy link
Member

@ArcturusZhang ArcturusZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@live1206 live1206 added this pull request to the merge queue Nov 22, 2024
Merged via the queue into microsoft:main with commit d8b2c45 Nov 22, 2024
21 checks passed
@live1206 live1206 deleted the refine-uri-builder branch November 22, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants