fix a11y warnings in website #5147
Merged
+31
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisradek
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
|
No changes needing a change description found. |
|
You can try these changes here
|
markcowl
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
@chrisradek Is there a way we can get the tool to run on our PRs? Generally, it would be nice to not regress once we are clean on these suppressions. If unknown, we should probably file an issue to see what can be done here.
|
@allenjzhang or @mario-guerra do you know if there's a way to automate running the accessibility tool? When I tried running it locally I had to visit individual web pages and it didn't pick up quite everything the report I worked off of did. |
|
We can just let it merge and request another scan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update addresses fixing the a11y findings in #5133
List of changes:
Will need to rerun analysis as local analysis didn't capture every item in the original report.