Report diagnostics for unused "using" and "import" so that they will be shown properly in ide #5146
+2,916
−184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RodgeFu
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
RodgeFu
changed the title
RodgeFu
changed the title
|
All changed packages have been documented.
Show changes
|
RodgeFu
commented
Nov 19, 2024
| // the projection statements will only be processed when applying projection. There is no way to determine | ||
| // whether "import" or "using" is referenced from them, so we just skip here to avoid providing incorrect suggestions (diagnostics) | ||
| // This should be fine for now considering projection is an experiemental feature. | ||
| for (const node of processedProjections) { |
There was a problem hiding this comment.
@timotheeguerin , I tried to check the project part code and can't find a way to identify the references as commented here. Please let me know if there is some way I missed to count them considering my knowledge in compiler is still limited. thanks.
|
You can try these changes here
|
RodgeFu
commented
Nov 19, 2024
| @@ -164,6 +169,7 @@ export async function createSourceLoader( | |||
| if (options?.getCachedScript) { | |||
| const old = options.getCachedScript(file); | |||
| if (old?.file === file && deepEquals(old.parseOptions, options.parseOptions)) { | |||
| mutate(old).importedBy = []; | |||
There was a problem hiding this comment.
@timotheeguerin , I am not very comfortable modifying the old object here, but I can't find a better place to put the importedBy information. Any suggestion here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When "using" and "import" are not needed, dim them and provide quickfix in IDE.
related issues:
#3373 , #4861