Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[http-server-csharp]: Fix #4308 Process sub-namespace of a service #5140

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

[http-server-csharp]: Fix #4308 Process sub-namespace of a service #5140

wants to merge 12 commits into from
+546 −52

Conversation

markcowl
Copy link
Contributor

No description provided.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Nov 18, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/http-server-csharp
Show changes

@typespec/http-server-csharp - fix ✏️

Fix #4308 Process sub-namespace of a service in csharp service emitter,> Fix #4998 Generator throws on void return type,> Fix #5000 Tuple types are not properly generated,> Fix #5001 OkResponse is generated as a model,> Fix #5024 Literal type is not properly generated,> Fix #5124 Templated model reported error while generating,> Fix #5125 No interfaces and controllers are generated for ops in a namespace

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@markcowl markcowl mentioned this pull request Nov 18, 2024
Open
This was linked to issues Nov 19, 2024
[http-server-csharp] No interfaces and controllers generated when ops are wrapped inside a namespace #5125
Open
[http-server-csharp] Templated model reported error when generating #5124
Open
[http-server-csharp] generator throws error when void is the return type in operation #4998
Open
[Bug]: @typespec/http-server-csharp does not emit models from subnamespaces #4308
Open
[http-server-csharp] literal type is not properly generated #5024
Open
[http-server-csharp] tuple types are not properly generated #5000
Open
@markcowl markcowl linked an issue Nov 21, 2024 that may be closed by this pull request
[http-server-csharp] OkResponse is generated as a model #5001
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@AlitzelMendez AlitzelMendez

@chrisradek chrisradek

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@markcowl @azure-sdk @AlitzelMendez @chrisradek