http-client-java, namespace from client.tsp #5051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:java
weidongxu-microsoft
changed the title
|
No changes needing a change description found. |
weidongxu-microsoft
force-pushed
the
http-client-java_namespace
branch
from
bb12836
to
e6731bd
Compare
|
You can try these changes here
|
weidongxu-microsoft
force-pushed
the
http-client-java_namespace
branch
3 times, most recently
from
e2b6d23
to
7fe1493
Compare
weidongxu-microsoft
force-pushed
the
http-client-java_namespace
branch
from
7fe1493
to
bf032f6
Compare
…ngxu-microsoft/typespec into http-client-java_namespace
weidongxu-microsoft
force-pushed
the
http-client-java_namespace
branch
from
2150213
to
4083889
Compare
...st/src/main/java/_specs_/azure/clientgenerator/core/access/InternalOperationAsyncClient.java
Show resolved
Hide resolved
4 tasks
weidongxu-microsoft
requested review from
srnagar,
haolingdong-msft and
XiaofeiCao
as code owners
haolingdong-msft
approved these changes
Nov 22, 2024
|
Locally tested the migration for openai to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
link Azure/autorest.java#2968
current limitation:
mostly this due to the fact that ctor of the client is package private, so it won't work if client and its builder or client of accessor method are in different packages
At this PR, unbranded would still have
.modelsin package for models. We can tweak this later (by settingmodelsSubPackagein JavaSetting to empty, when unbranded).tested and it be backward compatible, if
namespaceis provided in emitter optionhttps://github.com/Azure/azure-sdk-for-java/pull/43055/files