Error on augment expr #4926
Open
Error on augment expr #4926
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheeguerin
added
the
breaking-change
|
❌ There is undocummented changes. Run The following packages have changes but are not documented.
Show changes |
|
You can try these changes here
|
timotheeguerin
force-pushed
the
error-on-augment-expr
branch
from
34961b4
to
94bf164
Compare
microsoft-github-policy-service
bot
added
the
compiler:core
timotheeguerin
requested review from
bterlson,
markcowl and
allenjzhang
as code owners
timotheeguerin
commented
Nov 7, 2024
| @@ -5165,6 +5165,18 @@ export function createChecker(program: Program, resolver: NameResolver): Checker | |||
| target: node.targetType, | |||
| }), | |||
| ); | |||
| } else if ( | |||
There was a problem hiding this comment.
If someone wants to take over this PR during my leave I think the remaining items are:
- this probably should also error for union expression
- add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pr off #4849 that adds a breaking change that validate that you cannot augment model expression instead of just silently failing
Needs to be rebased when #4849 is merged