Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] add chronus version managing #4676

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
+14 −2
Open

[python] add chronus version managing #4676

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e26fa11
add chronus check to pipeline
Oct 10, 2024
1799beb
update scripts in package.json
Oct 10, 2024
3784041
Merge branch 'main' into python/addChronus
tadelesh Oct 11, 2024
a5604f3
Merge branch 'main' into python/addChronus
tadelesh Oct 14, 2024
39ce348
Merge branch 'main' into python/addChronus
msyyc Oct 15, 2024
533b13f
Merge branch 'main' of https://github.com/microsoft/typespec into pyt…
Oct 17, 2024
32faba7
try to add python-client version policy
Oct 17, 2024
4a322ad
add changeset
Oct 17, 2024
3dc90ec
add back git changes bc of ci failure
Oct 17, 2024
1c063a6
Merge branch 'main' into python/addChronus
msyyc Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .chronus/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,17 @@ versionPolicies:
- "@typespec/sse"
- "@typespec/streams"
- "@typespec/xml"
- name: python-client
type: independent
step: patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
step: patch

step is for lockStep only

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at the previous policy, it has type: lockstep and step: minor so I'm kind of confused

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went with step: patch instead of step: minor since I don't want to only officially release minor versions, but let me know if my understanding here isn't right

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you use lockStep policy it means all package in the policy will always increase by the given step. For independant it will just respect the change description(if you do major, minor, patch,etc.)

packages:
- "@typespec/http-client-python"

changelog: ["@chronus/github/changelog", { repo: "microsoft/typespec" }]

ignore:
- "@typespec/http-client-csharp"
- "@typespec/http-client-java"
- "@typespec/http-client-python"

changedFiles:
- "!**/*.md"
Expand Down
22 changes: 0 additions & 22 deletions packages/http-client-python/eng/scripts/Check-GitChanges.ps1
View file
Open in desktop

This file was deleted.

3 changes: 2 additions & 1 deletion packages/http-client-python/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@
"ci": "npm run test:emitter && npm run ci:generator --",
"ci:generator": "tsx ./eng/scripts/ci/run-ci.ts",
"test:generator": "tsx ./eng/scripts/ci/run-ci.ts --command=test",
"test:emitter": "vitest run -c ./emitter/vitest.config.ts"
"test:emitter": "vitest run -c ./emitter/vitest.config.ts",
"change": "chronus"
iscai-msft marked this conversation as resolved.
Show resolved Hide resolved
},
"files": [
"dist/**",
Expand Down
Loading