Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Refs to Microsoft.Quantum in Samples and Katas #2030

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Remove Refs to Microsoft.Quantum in Samples and Katas #2030

wants to merge 13 commits into from

Conversation

ScottCarda-MS
Copy link
Contributor

@ScottCarda-MS ScottCarda-MS commented Nov 15, 2024 •
edited
Loading

  • Removed references to Microsoft.Quantum.Unstable libraries from Samples.
  • Removed references to Microsoft.Quantum libraries from Katas.
  • Renamed Microsoft.Quantum.Katas namespace to KatasUtils, but left in reexports from Microsoft.Quantum.Katas for legacy solutions.
  • Corrected some minor spelling and capitalization typos in the Samples and Katas.

@ScottCarda-MS ScottCarda-MS changed the title Samples Updates Remove Refs to Microsoft.Quantum in Samples and Katas Nov 15, 2024
@ScottCarda-MS ScottCarda-MS marked this pull request as ready for review November 15, 2024 23:54
@DmitryVasilevsky DmitryVasilevsky linked an issue Nov 16, 2024 that may be closed by this pull request
Update references to unstable #2027
Open
@github-actions GitHub Actions
Copy link

Change in memory usage detected by benchmark.

Memory Report for b793e70

Test This Branch On Main Difference
compile core + standard lib 19560401 bytes 19560417 bytes -16 bytes

swernli
swernli approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@swernli swernli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a closer review of the library and samples, and spot checked the katas (there's a lot of those!). Seems ready to me!

@DmitryVasilevsky
Copy link
Contributor

It all looks good in general, but autoformatting of literal strings and lists made the code less readable. I would prefer that old formatting be kept in many cases.

@github-actions GitHub Actions
Copy link

Change in memory usage detected by benchmark.

Memory Report for c223117

Test This Branch On Main Difference
compile core + standard lib 19560401 bytes 19560417 bytes -16 bytes

@github-actions GitHub Actions
Copy link

Change in memory usage detected by benchmark.

Memory Report for 5a04b69

Test This Branch On Main Difference
compile core + standard lib 19560401 bytes 19560417 bytes -16 bytes

@github-actions GitHub Actions
Copy link

Change in memory usage detected by benchmark.

Memory Report for 2612222

Test This Branch On Main Difference
compile core + standard lib 19560401 bytes 19560417 bytes -16 bytes

@github-actions GitHub Actions
Copy link

Change in memory usage detected by benchmark.

Memory Report for 17c1327

Test This Branch On Main Difference
compile core + standard lib 19560401 bytes 19560417 bytes -16 bytes

@github-actions GitHub Actions
Copy link

Change in memory usage detected by benchmark.

Memory Report for 8624076

Test This Branch On Main Difference
compile core + standard lib 19560401 bytes 19560417 bytes -16 bytes

@github-actions GitHub Actions
Copy link

Change in memory usage detected by benchmark.

Memory Report for 20e1eec

Test This Branch On Main Difference
compile core + standard lib 19560401 bytes 19560417 bytes -16 bytes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitryVasilevsky DmitryVasilevsky DmitryVasilevsky left review comments

@swernli swernli swernli approved these changes

@sezna sezna Awaiting requested review from sezna sezna is a code owner

@tcNickolas tcNickolas Awaiting requested review from tcNickolas tcNickolas is a code owner

@billti billti Awaiting requested review from billti billti is a code owner

@minestarks minestarks Awaiting requested review from minestarks minestarks is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update references to unstable
3 participants
@ScottCarda-MS @DmitryVasilevsky @swernli