-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate nonlocal games 1596 task2 ghz quantum #1840
base: main
Are you sure you want to change the base?
Migrate nonlocal games 1596 task2 ghz quantum #1840
Conversation
This week got crazy, so I didn't get to reviewing this - sorry about that! I'll look on Monday, my calendar is a lot clearer then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at the two tasks this PR adds and left some comments. I'll take a look at the discussion and the demo tomorrow, sorry I can't finish it today, so decided to post a partial review. (Though the comment about not defining variable when measuring can be applied to the demo as well)
Thank you!
katas/content/nonlocal_games/ghz_create_entangled_triple/index.md
Outdated
Show resolved
Hide resolved
katas/content/nonlocal_games/ghz_create_entangled_triple/index.md
Outdated
Show resolved
Hide resolved
katas/content/nonlocal_games/ghz_create_entangled_triple/index.md
Outdated
Show resolved
Hide resolved
katas/content/nonlocal_games/ghz_create_entangled_triple/index.md
Outdated
Show resolved
Hide resolved
katas/content/nonlocal_games/ghz_create_entangled_triple/index.md
Outdated
Show resolved
Hide resolved
katas/content/nonlocal_games/ghz_quantum_strategy/Verification.qs
Outdated
Show resolved
Hide resolved
katas/content/nonlocal_games/ghz_quantum_strategy/Verification.qs
Outdated
Show resolved
Hide resolved
Co-authored-by: Mariia Mykhailova <[email protected]>
Co-authored-by: Mariia Mykhailova <[email protected]>
Co-authored-by: Mariia Mykhailova <[email protected]>
…ion.md Co-authored-by: Mariia Mykhailova <[email protected]>
Co-authored-by: Mariia Mykhailova <[email protected]>
Co-authored-by: Mariia Mykhailova <[email protected]>
Co-authored-by: Mariia Mykhailova <[email protected]>
…/github.com/ggridin/qsharp into MigrateNonlocalGames-1596-task2-GHZ-quantum
@tcNickolas - Maria, comments are addressed, waiting for re-review. |
Co-authored-by: César Zaragoza Cortés <[email protected]>
The link to the issue: #1596
This pull request covering