Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call unstick_channels to mitigate the lost synic issue #376

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

juantian8seattle
Copy link

@juantian8seattle juantian8seattle commented Nov 21, 2024

This PR addresses an issue where the synic event was lost during the save process. To mitigate this issue during the restore process, we have introduced a new field lost_synic_bug_fixed in the SavedState structure. The lost_synic_bug_fixed field will indicate whether the issue was fixed in save code path. During the restore process, we check if the field is not set then unstick_channels() function is called to mitigate the issue.

In below kmsg traces, yellow line shows we check the field to see if need call unstick_channels and green line shows we did hit the issue where the rings were not empty and need signal the guest:

image

@juantian8seattle juantian8seattle requested a review from a team as a code owner November 21, 2024 21:38
@juantian8seattle juantian8seattle self-assigned this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants