Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flowey: build hypestv in CI #375

Merged
merged 2 commits into from
Nov 21, 2024
Merged

flowey: build hypestv in CI #375

merged 2 commits into from
Nov 21, 2024

Conversation

jstarks
Copy link
Member

@jstarks jstarks commented Nov 21, 2024

This ensures hypestv continues to build, plus it will be useful to be able to grab hypestv as an artifact.

This ensures hypestv continues to build, plus it will be useful to be
able to grab hypestv as an artifact.
@jstarks jstarks requested review from a team as code owners November 21, 2024 20:09
@jstarks
Copy link
Member Author

jstarks commented Nov 21, 2024

@daprilik, artifact_hypestv in particular seems like boilerplate that could be shared across all the host-side tools. Am I wrong?

@daprilik
Copy link
Contributor

@daprilik, artifact_hypestv in particular seems like boilerplate that could be shared across all the host-side tools. Am I wrong?

Yes, I think there's certainly an avenue to consolidate that sort of common "simple rust bin" artifact logic. I think there are a few approaches on how to achieve that, though the one that I lean towards is doing something similar to SimpleFlowNode, where you can implement a special ArtifactFlowNode trait which has overrides for various artifact-specific things (e.g: bin name, etc..), and have it then impl the FlowNode for you.

also pinging @benhillis, @justus-camp-microsoft, as an FYI / for visibility

@benhillis
Copy link
Member

@daprilik, artifact_hypestv in particular seems like boilerplate that could be shared across all the host-side tools. Am I wrong?

Yes, I think there's certainly an avenue to consolidate that sort of common "simple rust bin" artifact logic. I think there are a few approaches on how to achieve that, though the one that I lean towards is doing something similar to SimpleFlowNode, where you can implement a special ArtifactFlowNode trait which has overrides for various artifact-specific things (e.g: bin name, etc..), and have it then impl the FlowNode for you.

also pinging @benhillis, @justus-camp-microsoft, as an FYI / for visibility

Agreed, less boilerplate is better. Did you or John want to open an issue?

@daprilik
Copy link
Contributor

daprilik commented Nov 21, 2024

I can spin up a tracking issue

See #377

@jstarks jstarks merged commit b7ce785 into microsoft:main Nov 21, 2024
25 checks passed
@jstarks jstarks deleted the hypest-pub branch November 21, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants