Pin Vtl2 memory if its being carve out by itself #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarks
reviewed
Oct 21, 2024
| use hvdef::hypercall::HvInputVtl; | ||
| use hvdef::HV_PAGE_SIZE; | ||
| use memory_range::MemoryRange; | ||
| use minimal_rt::arch::hypercall::invoke_hypercall; | ||
| use zerocopy::AsBytes; | ||
|
|
||
| const PIN_REQUEST_HEADER_SIZE: usize = size_of::<hvdef::hypercall::PinUnpinGpaPageRangesHeader>(); |
There was a problem hiding this comment.
Move this into the relevant function
jstarks
reviewed
Oct 21, 2024
| let mut ranges = ArrayVec::new(); | ||
|
|
||
| // Calculate the total number of pages in the memory range | ||
| let total_pages = (memory_range.end() - memory_range.start()).div_ceil(PAGE_SIZE); |
jstarks
reviewed
Oct 21, 2024
| let total_pages = (memory_range.end() - memory_range.start()).div_ceil(PAGE_SIZE); | ||
|
|
||
| // Iterate over the memory range in chunks of 2048 pages | ||
| let mut current_page = memory_range.start() >> 12; // Convert start address to page number |
jstarks
reviewed
Oct 21, 2024
| ranges.push(HvGpaRange( | ||
| HvGpaRangeExtended::new() | ||
| .with_additional_pages(pages_in_this_range - 1) | ||
| .with_large_page(false) |
There was a problem hiding this comment.
Why not use the large pages when possible?
jstarks
reviewed
Oct 21, 2024
| let mut current_page = memory_range.start() >> 12; // Convert start address to page number | ||
| let mut remaining_pages = total_pages; | ||
|
|
||
| while remaining_pages > 0 { |
There was a problem hiding this comment.
I recommend doing something like while current_page < memory_range.end_4k_gpn() and removing remaining_pages as a separate variable. IMO it's almost always better to have a single loop variable.
jstarks
reviewed
Oct 21, 2024
| let header = hvdef::hypercall::PinUnpinGpaPageRangesHeader { reserved: 0 }; | ||
| let input_offset = size_of::<hvdef::hypercall::PinUnpinGpaPageRangesHeader>(); | ||
|
|
||
| while remaining_size_bytes > 0 { |
jstarks
reviewed
Oct 21, 2024
|
|
||
| while remaining_size_bytes > 0 { | ||
| // Determine the size for this chunk of memory | ||
| let chunk_bytes = cmp::min(remaining_size_bytes, max_bytes_per_request); |
There was a problem hiding this comment.
I'd just write let chunk_end = (current_start + max_bytes_per_request).min(memory_range.end())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin VTL2 memory if it is being carved out independently. In the current implementation, specifically in add-on mode, the host ensures that VTL2 memory is physically backed. This change enhances that mechanism by explicitly pinning the VTL2 memory when it is carved out.