Shutdown relay device should mirror guest connectivity #144
Conversation
Can we avoid this in the case where we're not rolling back to an old version? If we do roll back and the channel was previously offered, nothing will be there to restore it, and so it will get automatically revoked at that time. Or at least, that's what's supposed to happen. |
Rescind guest shutdown device on stop in case VM is moving to a version that does not support shutdown relay. Move majority of shutdown relay logic to new ShutdownRelayDevice object.
…annel to a running device. When the shutdown device is closed, the notificiation channel is also closed. When the device starts up again, a new notification channel is provided.
John and I had an offline discussion about this. There is an issue with the save state, in that if save state exists for a device that is not present, it is considered an error. There is potential future work here to either support optional save state (ignored when unused), or a more extreme "no save state" option that actually removes all references. |
Mirror guest vmbus connection status with shutdown device. This allows the host to determine if there is a shutdown device connected.
Rescind guest shutdown device on stop in case VM is moving to a version that does not support shutdown relay (e.g. moving to an older version). If the VM resumes without support for the shutdown relay device, the host device will be enumerated as a new device to the guest and will be used directly. If the resume occurs with support, it will just be setup again. This does mean the guest will see device removal/arrival around operations like servicing.
The logic for dealing with the shutdown relay has gotten hefty enough that it has been moved into its own file.