Skip to content

Commit

Permalink
Add Param dotNotUpdateVersionNumber to New-AppSourceSubmission (#3221)
Browse files Browse the repository at this point in the history
fixes #3220 

Hi Freddy,

new AppSource guidelines seem to support hotfixes only when the app
version in the offer properties stays untouched.

I thought about reusing the check Param, but the naming would be a bit
off.

I tested this with an offer and the hotfix went through validation now.

What do you think?
  • Loading branch information
JulianSchmidtkeGWS authored Oct 26, 2023
1 parent c4ca947 commit 47971a0
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
8 changes: 6 additions & 2 deletions AppSource/New-AppSourceSubmission.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
Include this switch if you do not want the method to display URLs etc.
.Parameter doNotCheckVersionNumber
Include this switch avoid checking whether the new version number is greater than the existing version number in Partner Center
.Parameter doNotUpdateVersionNumber
Include this switch when you do not want to change the version number of the product in Partner Center (can be used for hotfixes)
.Example
New-AppSourceSubmission -authContext $authContext -productId $product.Id -appFile $appFile
.Example
Expand All @@ -40,7 +42,9 @@ function New-AppSourceSubmission {
[switch] $doNotWait,
[switch] $force,
[switch] $silent,
[switch] $doNotCheckVersionNumber
[Obsolete("doNotCheckVersionNumber is obsolete, please use doNotUpdateVersionNumber instead")]
[switch] $doNotCheckVersionNumber,
[switch] $doNotUpdateVersionNumber
)

$telemetryScope = InitTelemetryScope -name $MyInvocation.InvocationName -parameterValues $PSBoundParameters -includeParameters @()
Expand Down Expand Up @@ -197,7 +201,7 @@ try {
}
)
}
if ($appVersionNumber) {
if ($appVersionNumber -and !$doNotUpdateVersionNumber) {
$branchesProperty = @(Invoke-IngestionApiGetCollection -authContext $authContext -path "/products/$productId/branches/getByModule(module=Property)" -silent:($silent.IsPresent) | Where-Object {
$thisVariantID = ''
if ($_.PSObject.Properties.name -eq "variantID") { $thisVariantID = $_.variantID }
Expand Down
2 changes: 2 additions & 0 deletions ReleaseNotes.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
6.0.1
New-AadAppsForBC doesn't work with the newer versions of Microsoft.Graph module (where the type of the accesstoken parameter has changed)
New-AppSourceSubmission has a new parameter -doNotUpdateVersionNumber to support hotfixes in AppSource for earlier versions
New-AppSourceSubmission obsoleted parameter -doNotCheckVersionNumber that was previously used for hotfixes, because of a change in AppSource

6.0.0
Add parameter -accept_insiderEULA on New-BcContainer, Get-BcArtifactUrl and Run-AlPipeline to accept the insider EULA (https://go.microsoft.com/fwlink/?linkid=2245051) instead of using the insider SAS token.
Expand Down

0 comments on commit 47971a0

Please sign in to comment.