Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/validation rules openapi #5691

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Conversation

samwelkanda
Copy link
Contributor

closes #5162

@samwelkanda samwelkanda marked this pull request as ready for review October 30, 2024 10:31
@samwelkanda samwelkanda requested a review from a team as a code owner October 30, 2024 10:31
Copy link

sonarcloud bot commented Nov 6, 2024

Comment on lines +70 to +73
OpenApiServerUrlRule.ServerUrlMustBeHttps,
OpenApiAuthFlowRule.OnlyAuthorizationCodeFlowAllowed(OAIDocument.SecurityRequirements),
OpenApiCombinedAuthFlowRule.PathsCanOnlyHaveOneSecuritySchemePerOperation(OAIDocument.SecurityRequirements),
OpenApiRequestBodySchemaRule.RequestBodySchemaObjectsMustNeverBeNested,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there should be more validations than these.

See #5162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Epic] Validation rules for Plugin Generation in Kiota
3 participants