Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: remove 'no entry' icon #5683

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Conversation

thewahome
Copy link
Contributor

@thewahome thewahome commented Oct 29, 2024

Overview

Closes #5219

Demo

image

@thewahome thewahome requested a review from a team as a code owner October 29, 2024 10:51
calebkiage
calebkiage previously approved these changes Oct 30, 2024
@calebkiage calebkiage dismissed their stale review October 30, 2024 11:05

There should be a padding applied when the icon is not used to match the screenshot in the issue

@calebkiage
Copy link
Contributor

Is it possible to add a padding to align the text as shown in the screenshot attached to the issue?

image

Copy link

sonarcloud bot commented Oct 31, 2024

@thewahome thewahome merged commit 745a4ac into main Oct 31, 2024
203 of 205 checks passed
@thewahome thewahome deleted the task/extension/remove-noEntry-icon branch October 31, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

TreeView icons are still using the "no entry" icon compared to the design
2 participants