Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP - Authentication Provider for Microsoft Identity platform #1201

Merged
merged 19 commits into from
Feb 21, 2022
Merged

PHP - Authentication Provider for Microsoft Identity platform #1201

merged 19 commits into from
Feb 21, 2022

Conversation

Ndiritu
Copy link
Contributor

@Ndiritu Ndiritu commented Feb 14, 2022 •
edited
Loading

Uses PHP League's OAuth 2.0 client to build an Authentication provider for Azure Identity

@Ndiritu Ndiritu self-assigned this Feb 14, 2022
@Ndiritu Ndiritu added this to the Community Preview milestone Feb 14, 2022
@Ndiritu Ndiritu added the PHP label Feb 14, 2022
@Ndiritu Ndiritu changed the title PHP - Authentication Provider for Azure Identity PHP - Authentication Provider for Microsoft Identity platform Feb 14, 2022
baywet
baywet reviewed Feb 15, 2022
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this, a couple of comments to help the progress.
On top of this, we're probably missing a certificate experience, and some kind of public client experience (device code?)

README.md Outdated Show resolved Hide resolved
authentication/php/phpleague/src/PhpLeagueAccessTokenProvider.php Outdated Show resolved Hide resolved
authentication/php/phpleague/src/PhpLeagueAccessTokenProvider.php Outdated Show resolved Hide resolved
authentication/php/phpleague/src/PhpLeagueAccessTokenProvider.php Outdated Show resolved Hide resolved
@Ndiritu Ndiritu mentioned this pull request Mar 20, 2023
Open
@Ndiritu Ndiritu marked this pull request as ready for review February 21, 2022 08:43
@sonarcloud
Copy link

sonarcloud bot commented Feb 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Ndiritu Ndiritu merged commit 230e65d into main Feb 21, 2022
@Ndiritu Ndiritu deleted the feat/php/authentication branch February 21, 2022 13:59
@Ndiritu Ndiritu restored the feat/php/authentication branch February 21, 2022 13:59
@Ndiritu Ndiritu deleted the feat/php/authentication branch February 21, 2022 13:59
@baywet baywet linked an issue Feb 21, 2022 that may be closed by this pull request
Implement Azure Identity Authentication Provider #787
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@andrueastman andrueastman Awaiting requested review from andrueastman

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@zengin zengin Awaiting requested review from zengin

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@ddyett ddyett Awaiting requested review from ddyett

@peombwa peombwa Awaiting requested review from peombwa

@nikithauc nikithauc Awaiting requested review from nikithauc

@ramsessanchez ramsessanchez Awaiting requested review from ramsessanchez

Assignees

@Ndiritu Ndiritu

Labels
PHP
Projects
None yet
Milestone
Community Preview
Development

Successfully merging this pull request may close these issues.

Implement Azure Identity Authentication Provider
2 participants
@Ndiritu @baywet