genai comments #687
Annotations
3 errors
|
genaiscript pr-review-commit:
packages/core/src/cache.ts#L30
The `name` parameter in the `byName` method is not validated for being a non-empty string. This could lead to unexpected behavior if an empty string or a string with only whitespace is passed.
|
|
genaiscript pr-review-commit:
packages/core/src/comments.ts#L10
The `commentsCache` function does not handle potential errors that might occur during the execution of `JSONLineCache.byName`. It's recommended to add error handling to prevent potential crashes or unexpected behavior.
|
|
genaiscript pr-review-commit:
packages/vscode/src/comments.ts#L19
The `activateComments` function creates comment threads and pushes them to the `subscriptions` array, but there is no cleanup logic to remove these subscriptions when they are no longer needed. This could potentially lead to memory leaks.
|
Loading