Update UnitConverterDataLoader.cpp #2033
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue microsoft#2026 Due to incorrect value of `ViewMode::Speed, UnitConverterUnits::Speed_MilesPerHour, 44.7`, calculated value was different from actual (which should be) `ViewMode::Speed, UnitConverterUnits::Speed_MilesPerHour, 44.704`. Please correct me if I am wrong, this is my first contribution.
|
I am new to open source, please correct me if I am wrong, I would be really grateful! Thank you |
sravanth-space
approved these changes
Jul 28, 2023
|
Respected Devs, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2026
Fixes #.
Due to incorrect value of 44.7, result varied as given in the issue.
The originally calculated value was different from actual (which should be)
Description of the changes:
Speed_MilesPerHourHow changes were validated: