-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update versions for generators #4796
Conversation
Pull Request Test Coverage Report for Build 11958877849Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clarify which versions we want to target from the templates
discuss node versions support
generators/generator-botbuilder/generators/app/templates/core/package-with-tests.json.js
Show resolved
Hide resolved
generators/generator-botbuilder/generators/app/templates/core/package-with-tests.json.ts
Outdated
Show resolved
Hide resolved
@@ -3,13 +3,15 @@ | |||
"composite": true, | |||
"declaration": true, | |||
"target": "es2017", | |||
"module": "commonjs", | |||
"module": "NodeNext", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the motivation to diverge from commonjs? afaik we have not finalized support to latest node
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend to keep using commonjs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I was confused, the value for moduleResolution
must match the one for module
. it does not work with commonjs, but NodeNext supports both CommonJS and ECMAScript modules (documentation).
@rido-min This purpose was to support creating and versioning the generators package during build. This is to allow the generators to be built and deployed whenever we do a release of the JS SDK. This does not encompass template specific issues, though we could also make changes there if needed. |
#minor
Description
This PR includes the generators' templates to be updated by the update-versions script by including them in the workspaces list.
It also updates the versions in the package.json file to match the one used in the libraries (4.1.6) and upgrades some dependencies in the TS bots to fix errors found when building the generated bots.
Specific Changes
Testing
These images show the updated version in the bots and the bots working with the changes.