Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Fix test:consumer pipeline randomly failing #4793

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

sw-joelmut
Copy link
Collaborator

#minor

Description

This PR refactors the test:consumer script to reduce the chance of the random failing issue to happen by using Mocha retries. Additionally, by moving the script to Mocha tests, the formatted output is better as each typescript version is shown as a test.

Specific Changes

  • Removed the run.ts file.
  • Removed unnecessary dependencies.
  • Added a generateTests.ts file that is in charge of generating the typescript Mocha tests so they can be run in parallel. All tests are generated under the tests/generated folder (git ignored).
  • Added typescript.js, which is the file containing the test logic.

Testing

The following image shows the new formatting.
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner November 12, 2024 12:34
@coveralls
Copy link

coveralls commented Nov 12, 2024

Pull Request Test Coverage Report for Build 11797358149

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.704%

Totals Coverage Status
Change from base Build 11687414604: 0.0%
Covered Lines: 20515
Relevant Lines: 23064

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit ba67046 into main Nov 22, 2024
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/update/test-consumer branch November 22, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants