Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: [#4684] Upgrade chai using import-sync for esm-only package #4792

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sw-joelmut
Copy link
Collaborator

Addresses #4684
#minor

Description

This PR updates the chai package to its latest version 5.1.2. Starting on version 5.x, this package is ESM-only, so we used import-sync to be able to use this version.

Specific Changes

  • Updated chai from 4.5.0 and 5.1.2 in botbuilder and botframework-streaming libraries.
  • Added import-sync as a dependency in botbuilder and botframework-streaming.
  • Added chai to the depcheck ignore list as it threw a false positive on unused dependency.

Testing

The following images show the installed version.
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner November 12, 2024 12:33
@coveralls
Copy link

coveralls commented Nov 12, 2024

Pull Request Test Coverage Report for Build 11797338556

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.704%

Totals Coverage Status
Change from base Build 11687414604: 0.0%
Covered Lines: 20515
Relevant Lines: 23064

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants