Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agent name termination #4123

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Agent name termination #4123

wants to merge 10 commits into from
+63 −1

Conversation

thainduy
Copy link

Why are these changes needed?

Introduces the AgentNameTermination class, which is a termination condition for conversations based on last agent name

Related issue number

Checks

@thainduy
Copy link
Author

@microsoft-github-policy-service agree

@thainduy
- Remove unnecessary message type check
f3470bc 
- Rename class to `SourceMatchTermination`
ekzhu
ekzhu requested changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this into autogen-agentchat, there is no external dependency.

@thainduy thainduy requested a review from ekzhu November 20, 2024 02:27
@thainduy
Copy link
Author

Let's move this into autogen-agentchat, there is no external dependency.

moved to autogen-agentchat, pls check again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekzhu ekzhu ekzhu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thainduy @ekzhu