Latest DrawingIsland changes #338
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the DrawingIsland sample using public WASDK 1.5 APIs.
Renamed C++ version into CppTest and created parallel C# / NET CsTest version. The Cs version is not working correctly with CsWinRT and .NET 8 yet. To get the C++ projects to successfully build, unload the Cs projects from the VS solution: - DrawingCsTestApp - DrawingCsTestPackage - DrawingIslandCsProjection
Thanks to Manodasan, this fixes the CsWinRT support. :-)
Resolve most #if/#endif blocks for either support or not. Remaining: - Mica on Win11 - Improve Accessibility
Move feature areas into sub-structs to partition. (Will continue this more.) Fix word-wrapping at 100 columns.
Members are now in a more readable order, members that are not used have been removed, and everything is better partitioned.
The experimental sample has now been completely superseded by the new WASDK 1.5 public DrawingIsland sample that shows both C++ and C# callers.
* Refactor UIA * Update UIA when visual ordering changes * Fix keyboard input and support UIA removal of all children --------- Co-authored-by: adpa-ms
jeffstall
requested review from
manodasanW,
Scottj1s,
gegao18,
ChewWorker and
JesseCol
JesseCol
approved these changes
May 6, 2024
* Add TextElement and TextRenderer classes. * Hook up the text element to the drawing island. * Rename VisualElement to VisualItem. * Add a margin around text. * Address code review feedback.
* Show how to consume LottieIsland * Changed LottieIsland to be based of command line argument * Rename LottieIslandScenario * Respond to Jeff's PR feedback --------- Co-authored-by: Jeffrey Stall <[email protected]>
Ported from SceneGraph Samples.
Co-authored-by: Adib Parkar <[email protected]>
Co-authored-by: Adib Parkar <[email protected]>
Co-authored-by: Adib Parkar <[email protected]>
) Co-authored-by: Andy Chen (ABC) <[email protected]>
Restore Duck and rename Helmet. Rewrite Helmet loading code: 1. Share common memory buffer code. 2. Execute file loading / bitmap decoding parallel. 3. Make more common functions to improve readability.
Co-authored-by: Adib Parkar <[email protected]>
The Cs projects run down-level to RS5. They should not require Win11.
* Add RecreateGraphicsDevice method. * Implement TextRenderer::RecreateDirect2DDevice. * Catch device-removed exceptions. * Add DeviceLostHelper class. * Handle device lost event. * DeviceLostHelper cleanup.
* Snap pixels on text surface brush and visual. * Disable stretching and alignment in Text's surface brush * Set visual to size of text surface to disable stretch/alignment * Correctly set a text item visual's size to match the surface size. --------- Co-authored-by: achen144 <[email protected]>
jonwis
reviewed
May 10, 2024
|
|
||
| This project demonstrates how to get started consuming Windows Runtime | ||
| classes directly from standard C++, using platform projection headers | ||
| generated from Windows SDK metadata files. |
There was a problem hiding this comment.
Can this file either be deleted, or converted to a .md explaining what the test app is doing and why?
|
|
||
| <Identity | ||
| Name="94c4cb2e-aad6-4713-8ea8-591be99dcbc9" | ||
| Publisher="CN=jstall" |
There was a problem hiding this comment.
Is there a standard Publisher field that the other samples in the repo use?
| <OutputType>WinExe</OutputType> | ||
|
|
||
| <!-- TODO: Why do we need to specify a specific Windows version? --> | ||
| <TargetFramework>net8.0-windows10.0.22621.0</TargetFramework> |
There was a problem hiding this comment.
Is it maybe the PSDK version tag here? The 22621 PSDK is backwards compatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add C# sample
Fix UIA usage
Target Release
WASDK 1.5 public.
Checklist
/azp run SamplesCI-<FeatureName>to have the CI build run on my branch for each of my FeatureName my PR is modifying. This must be done on the latest commit on the PR before merging to ensure the build is up to date and accurate. Warning: the PR will not block automatically if this is not run due to '/azp run' limitation on triggering more than 10 pipelines.