Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PowerFx to 1.1 #311

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Update PowerFx to 1.1 #311

merged 3 commits into from
Oct 10, 2023

Conversation

NavneetThekkumpat
Copy link
Contributor

@NavneetThekkumpat NavneetThekkumpat commented Oct 10, 2023

PowerFx version update.
Please note that currently PowerApps does not support decimal fully but floating-point numbers which was handled here #278.
Whereas, PowerFx by default considers numbers as decimal. Hence in the tests we had to convert number to right type since we do not handle case for decimal types yet in testengine.

Validation

Tested the new version with PAC CLI. Looks good and runs well.
image

Checklist

  • The code change is covered by unit tests. I have added tests that prove my fix is effective or that my feature works
  • I have performed end-to-end test locally.
  • New and existing unit tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I used clear names for everything
  • I have performed a self-review of my own code

@NavneetThekkumpat NavneetThekkumpat requested a review from a team as a code owner October 10, 2023 18:11
@NavneetThekkumpat NavneetThekkumpat marked this pull request as draft October 10, 2023 18:11
@NavneetThekkumpat NavneetThekkumpat marked this pull request as ready for review October 10, 2023 18:30
@NavneetThekkumpat NavneetThekkumpat self-assigned this Oct 10, 2023
@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
Microsoft.PowerApps.TestEngine 91% 87% 982
Summary 91% (2535 / 2792) 87% (597 / 684) 982

Minimum allowed line rate is 85%

@NavneetThekkumpat NavneetThekkumpat merged commit c23e7df into main Oct 10, 2023
10 checks passed
@NavneetThekkumpat NavneetThekkumpat deleted the update_powerfx_to_1_1 branch October 10, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants