Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI Input Sanitization #287

Closed
wants to merge 2 commits into from
Closed

CLI Input Sanitization #287

wants to merge 2 commits into from

Conversation

arpavan
Copy link
Contributor

@arpavan arpavan commented Aug 1, 2023

Description

Removed Guid.Empty from input sanitization with the idea as we don't want to error out the application for a valid Guid that has a value of "empty".

Checklist

  • The code change is covered by unit tests. I have added tests that prove my fix is effective or that my feature works
  • I have performed end-to-end test locally.
  • New and existing unit tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I used clear names for everything
  • I have performed a self-review of my own code

@arpavan arpavan marked this pull request as ready for review August 1, 2023 03:40
@arpavan arpavan requested a review from a team as a code owner August 1, 2023 03:40
@arpavan arpavan changed the title Users/arpavan/cli input sanitization CLI Input Sanitization Aug 2, 2023
@arpavan arpavan force-pushed the users/arpavan/cli-input-sanitization branch from b5060af to 43963a5 Compare August 2, 2023 21:04
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Code Coverage

Package Line Rate Branch Rate Complexity Health
Microsoft.PowerApps.TestEngine 91% 88% 923 ✔
Summary 91% (2455 / 2684) 88% (557 / 634) 923 ✔

Minimum allowed line rate is 85%

@arpavan arpavan closed this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NavneetThekkumpat NavneetThekkumpat NavneetThekkumpat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arpavan @NavneetThekkumpat