Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Use no-cookies youtube link #23175

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

Josmithr
Copy link
Contributor

@Josmithr Josmithr commented Nov 21, 2024

The new website was flagged by our privacy team for embedding a youtube video without ensuring no cookies were collected. This updates the only currently embedded youtube video on the site to ensure this is not the case, adds a re-usable React component to avoid introducing such issues in the future, and adds best practices documentation to the docs README.

@Josmithr Josmithr requested review from WayneFerrao and a team November 21, 2024 19:44
@Josmithr Josmithr changed the title fix(privacy): Use no-cookies youtube link fix(docs): Use no-cookies youtube link Nov 21, 2024
@github-actions github-actions bot added area: website base: main PRs targeted against main branch labels Nov 21, 2024
Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> [email protected] ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> [email protected] serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> [email protected] check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  170005 links
    1595 destination URLs
    1825 URLs ignored
       0 warnings
       0 errors


@Josmithr Josmithr merged commit b0a0675 into microsoft:main Nov 22, 2024
31 checks passed
@Josmithr Josmithr deleted the docs/fix-youtube-cookies branch November 22, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: website base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants