-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move chunk.ts file to core/tree #23173
base: main
Are you sure you want to change the base?
Conversation
@@ -11,7 +11,7 @@ import { | |||
type ITreeCursor, | |||
type ITreeCursorSynchronous, | |||
rootFieldKey, | |||
} from "../../core/index.js"; | |||
} from "../index.js"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A file should never import a file that exports things from itself. You will need to split this up into more specific imports of other files in core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated imports, which fixed the depcruise error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Coverage Summary
↓ packages.dds.tree.src.feature-libraries.chunked-forest:
Line Coverage Change: -0.19% Branch Coverage Change: -0.03%
Metric Name | Baseline coverage | PR coverage | Coverage Diff |
---|---|---|---|
Branch Coverage | 87.40% | 87.37% | ↓ -0.03% |
Line Coverage | 95.65% | 95.46% | ↓ -0.19% |
↑ packages.dds.tree.src.core.tree:
Line Coverage Change: 0.30% Branch Coverage Change: 0.03%
Metric Name | Baseline coverage | PR coverage | Coverage Diff |
---|---|---|---|
Branch Coverage | 96.56% | 96.59% | ↑ 0.03% |
Line Coverage | 88.09% | 88.39% | ↑ 0.30% |
Baseline commit: 645a1a0
Baseline build: 309185
Happy Coding!!
Code coverage comparison check passed!!
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Baseline commit: 6e79694 |
Description
Moves the
chunk.ts
tocore/tree
to separate some chunk interfaces and types from theChunkedForest
.