Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move chunk.ts file to core/tree #23173

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

daesunp
Copy link
Contributor

@daesunp daesunp commented Nov 21, 2024

Description

Moves the chunk.ts to core/tree to separate some chunk interfaces and types from the ChunkedForest.

@daesunp daesunp requested a review from a team as a code owner November 21, 2024 17:56
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: tree base: main PRs targeted against main branch labels Nov 21, 2024
@@ -11,7 +11,7 @@ import {
type ITreeCursor,
type ITreeCursorSynchronous,
rootFieldKey,
} from "../../core/index.js";
} from "../index.js";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A file should never import a file that exports things from itself. You will need to split this up into more specific imports of other files in core

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated imports, which fixed the depcruise error

Copy link
Collaborator

@msfluid-bot msfluid-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Coverage Summary

↓ packages.dds.tree.src.feature-libraries.chunked-forest:
Line Coverage Change: -0.19%    Branch Coverage Change: -0.03%
Metric NameBaseline coveragePR coverageCoverage Diff
Branch Coverage 87.40% 87.37% ↓ -0.03%
Line Coverage 95.65% 95.46% ↓ -0.19%
↑ packages.dds.tree.src.core.tree:
Line Coverage Change: 0.30%    Branch Coverage Change: 0.03%
Metric NameBaseline coveragePR coverageCoverage Diff
Branch Coverage 96.56% 96.59% ↑ 0.03%
Line Coverage 88.09% 88.39% ↑ 0.30%

Baseline commit: 645a1a0
Baseline build: 309185
Happy Coding!!

Code coverage comparison check passed!!

@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 467.24 KB 467.27 KB +35 Bytes
azureClient.js 564.01 KB 564.06 KB +49 Bytes
connectionState.js 724 Bytes 724 Bytes No change
containerRuntime.js 263.43 KB 263.45 KB +14 Bytes
fluidFramework.js 428.84 KB 428.85 KB +14 Bytes
loader.js 134.18 KB 134.19 KB +14 Bytes
map.js 42.71 KB 42.71 KB +7 Bytes
matrix.js 150.15 KB 150.16 KB +7 Bytes
odspClient.js 529.85 KB 529.89 KB +49 Bytes
odspDriver.js 97.88 KB 97.9 KB +21 Bytes
odspPrefetchSnapshot.js 42.81 KB 42.83 KB +14 Bytes
sharedString.js 166.23 KB 166.24 KB +7 Bytes
sharedTree.js 419.3 KB 419.3 KB +7 Bytes
Total Size 3.38 MB 3.38 MB +245 Bytes

Baseline commit: 6e79694

Generated by 🚫 dangerJS against 722f0e8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: tree area: dds Issues related to distributed data structures base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants