refactor: Use assert.equal() to see values when test fails #23172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: tests
alexvy86
commented
Nov 21, 2024
Comment on lines
-1032
to
-1035
| // For some reason TSC gets it wrong - it assumes that attachState is constant and that assert above | ||
| // established it's AttachState.Detached, so this comparison is useless. | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore |
There was a problem hiding this comment.
I just tried removing it and nothing complained. Might have been a transient issue that a TS server restart would have gotten rid of?
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Baseline commit: d94bd42 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
Includes ack'd ids in summarytest sometimes fails against routerlicious but the error output only saysfalse !== trueso we can't tell the actual value of the number that is being compared to 1. This PR updates a few asserts in that file so they'll give us the actual value instead of justexpected true, got falsein the output when the test fails.Reviewer Guidance
The review process is outlined on this wiki page.