Create preproductionDeployment.yml #23167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: build
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
alexvy86
reviewed
Nov 21, 2024
Comment on lines
+37
to
+42
| # Step 3: Install Dependencies | ||
| - name: Install Dependencies | ||
| run: | | ||
| cd docs | ||
| pnpm i --frozen-lockfile | ||
| pnpm run build |
There was a problem hiding this comment.
I'd suggest splitting the actual build into its own step
Comment on lines
+34
to
+35
| - name: Install pnpm | ||
| run: npm install -g pnpm |
There was a problem hiding this comment.
I wonder if corepack enable would accomplish the same thing here. It's what we have to run locally during a first-time setup of the repo. @tylerbutler might know?
Comment on lines
+58
to
+70
| # Step 5: Post Deployment Feedback (Optional) | ||
| - name: Post Deployment URL as PR Comment | ||
| if: success() | ||
| uses: actions/github-script@v6 | ||
| with: | ||
| script: | | ||
| const url = '${{ steps.deploy.outputs.preview_url }}'; | ||
| github.issues.createComment({ | ||
| issue_number: context.issue.number, | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| body: `✅ **Pre-production Deployment Successful** 🚀\n\nYou can view the changes here: ${url}` | ||
| }); |
There was a problem hiding this comment.
What happens if there's two concurrent PRs making changes to the site? Does each of them get their own separate URL?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds preproduction deployment Github Action