-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(client-presence): E2E testing for Presence package #23144
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Coverage Summary
↑ packages.framework.presence.src:
Line Coverage Change: 1.64% Branch Coverage Change: 2.51%
Metric Name | Baseline coverage | PR coverage | Coverage Diff |
---|---|---|---|
Branch Coverage | 88.57% | 91.08% | ↑ 2.51% |
Line Coverage | 73.96% | 75.60% | ↑ 1.64% |
Baseline commit: 86ee6ad
Baseline build: 308548
Happy Coding!!
Code coverage comparison check passed!!
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Baseline commit: 86ee6ad |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 7 changed files in this pull request and generated no suggestions.
Files not reviewed (3)
- packages/framework/presence/package.json: Language not supported
- packages/test/test-end-to-end-tests/package.json: Language not supported
- packages/test/test-version-utils/package.json: Language not supported
Comments skipped due to low confidence (1)
packages/framework/presence/src/datastorePresenceManagerFactory.ts:55
- The comment should be 'Factory class to create instances of
IPresence
in its own data store.'
* @internal
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
Description
Preliminary setup for E2E/audience integration testing for new presence package.
This PR also reshuffles files in testAPI that were out of order.