Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(client-presence): E2E testing for Presence package #23144

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

WillieHabi
Copy link
Contributor

@WillieHabi WillieHabi commented Nov 19, 2024

Description

Preliminary setup for E2E/audience integration testing for new presence package.

This PR also reshuffles files in testAPI that were out of order.

@github-actions github-actions bot added base: main PRs targeted against main branch area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: tests Tests to add, test infrastructure improvements, etc dependencies Pull requests that update a dependency file labels Nov 19, 2024
@WillieHabi WillieHabi changed the title tests(client-presence): E2E test setup for Presence package test(client-presence): E2E test setup for Presence package Nov 19, 2024
Copy link
Collaborator

@msfluid-bot msfluid-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Coverage Summary

↑ packages.framework.presence.src:
Line Coverage Change: 1.64%    Branch Coverage Change: 2.51%
Metric NameBaseline coveragePR coverageCoverage Diff
Branch Coverage 88.57% 91.08% ↑ 2.51%
Line Coverage 73.96% 75.60% ↑ 1.64%

Baseline commit: 86ee6ad
Baseline build: 308548
Happy Coding!!

Code coverage comparison check passed!!

@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Nov 19, 2024

@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 467.24 KB 467.27 KB +35 Bytes
azureClient.js 564.01 KB 564.06 KB +49 Bytes
connectionState.js 724 Bytes 724 Bytes No change
containerRuntime.js 263.43 KB 263.45 KB +14 Bytes
fluidFramework.js 427.22 KB 427.23 KB +14 Bytes
loader.js 134.18 KB 134.19 KB +14 Bytes
map.js 42.71 KB 42.71 KB +7 Bytes
matrix.js 150.15 KB 150.16 KB +7 Bytes
odspClient.js 529.85 KB 529.89 KB +49 Bytes
odspDriver.js 97.88 KB 97.9 KB +21 Bytes
odspPrefetchSnapshot.js 42.81 KB 42.83 KB +14 Bytes
sharedString.js 166.23 KB 166.24 KB +7 Bytes
sharedTree.js 417.68 KB 417.68 KB +7 Bytes
Total Size 3.38 MB 3.38 MB +245 Bytes

Baseline commit: 86ee6ad

Generated by 🚫 dangerJS against 1c362ff

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 7 changed files in this pull request and generated no suggestions.

Files not reviewed (3)
  • packages/framework/presence/package.json: Language not supported
  • packages/test/test-end-to-end-tests/package.json: Language not supported
  • packages/test/test-version-utils/package.json: Language not supported
Comments skipped due to low confidence (1)

packages/framework/presence/src/datastorePresenceManagerFactory.ts:55

  • The comment should be 'Factory class to create instances of IPresence in its own data store.'
* @internal

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

@WillieHabi WillieHabi changed the title test(client-presence): E2E test setup for Presence package test(client-presence): E2E testing for Presence package Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants