-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding pause/resume functionality for document lambdas #23138
base: main
Are you sure you want to change the base?
Conversation
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 9 changed files in this pull request and generated 2 suggestions.
Files not reviewed (4)
- server/routerlicious/packages/lambdas-driver/src/document-router/documentLambda.ts: Evaluated as low risk
- server/routerlicious/packages/lambdas-driver/src/document-router/documentPartition.ts: Evaluated as low risk
- server/routerlicious/packages/lambdas-driver/src/kafka-service/partitionManager.ts: Evaluated as low risk
- server/routerlicious/packages/lambdas/src/scriptorium/lambda.ts: Evaluated as low risk
Comments skipped due to low confidence (2)
server/routerlicious/packages/lambdas-driver/src/document-router/contextManager.ts:62
- [nitpick] The parameter name 'allowBackToOffset' is not very descriptive. Consider renaming it to 'resumeOffset'.
public setHead(head: IQueuedMessage, allowBackToOffset?: number | undefined) {
server/routerlicious/packages/lambdas-driver/src/document-router/contextManager.ts:99
- The new behavior introduced by the 'allowBackToOffset' parameter should be covered by tests to ensure it works as expected.
public setHead(head: IQueuedMessage, allowBackToOffset?: number | undefined) {
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
Description
Recently we added circuit breaker and pause/resume for scriptorium, i.e. partition lambdas. With this PR, I am adding the pause/resume functionality for document lambdas. It will be triggered by a document lambda during various circuit breaker states (pause during open, and resume during close). Currently no doc lambda is using circuit breaker, so this is just to add functionality which will not be triggered until we implement circuit breaker in any doc lambda.
Important changes:
Reviewer Guidance