-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tree): normalize the NeverField/NeverTree before validating repo su… #23122
base: main
Are you sure you want to change the base?
feat(tree): normalize the NeverField/NeverTree before validating repo su… #23122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Coverage Summary
↑ packages.dds.tree.src.feature-libraries.modular-schema:
Line Coverage Change: 0.10% Branch Coverage Change: 0.19%
Metric Name | Baseline coverage | PR coverage | Coverage Diff |
---|---|---|---|
Branch Coverage | 93.29% | 93.48% | ↑ 0.19% |
Line Coverage | 95.14% | 95.24% | ↑ 0.10% |
Baseline commit: 645a1a0
Baseline build: 309185
Happy Coding!!
Code coverage comparison check passed!!
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Baseline commit: 645a1a0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
* - All never trees dropped from the schema | ||
* - All never fields converted to explicit Forbidden fields | ||
*/ | ||
function normalizeStoredSchema( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this function needs its own unit test suite
…perset
Description
Add a function to normalize the store schema by cleaning up the
NeverField
/NeverTree
. This will help ensure that the logic forisRepoSuperset
aligns with the handling inallowsRepoSuperset
.AB#11525
Reviewer Guidance
The review process is outlined on this wiki page.