Allow unsigned as a full type #6885
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
|
Oh that's a bit odd. The commit message contains less info than the description on github which says explicitly that it was to match FXC. So there's that. |
python3kgae
approved these changes
Aug 28, 2024
llvm-beanz
reviewed
Sep 12, 2024
There was a problem hiding this comment.
I think there are a bunch of test cases that need to be written for this, particularly for sema cases.
Things like:
is_same<unsigned, uint>is_same<unsigned int, uint>is_same<unsigned int64_t, uint64_t>
What about long or short?
I had assumed we would actually remove the C keywords from Clang, so if we're not going to do that maybe we should discuss which ones we want to support in DXC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#106 disabled the unsigned keyword as a complete type specifier among other changes. This was to match FXC behavior which doesn't allow it. It's harmless and sure not to break any existing code. It also represents a discrepancy with the developing clang HLSL support that I'm not inclined to change there.
This restores the ability to promote a variable with just the
unsignedkeyword as anunsigned intand includes tests that affirm it's availability in a number of contexts and compatibility withuint