-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose natsjskv Watcher #142
base: main
Are you sure you want to change the base?
Conversation
Pipelines broken unrelated?
|
@asim is this something we would like to be merged? |
If the test pass and it's been go fmt then sure, why not |
89027d7
to
4bc93ff
Compare
@asim tests seem broken due to v5 update. Not sure what is going wrong. Unrelated to this PR:
|
I think the acme dir is gone? |
I do not know to be honest. I was not involved in v5 update and also didn't see any PRs. So I do not know what the change between v4 and v5 is and neither do I know how this affects v4 builds. |
I don't know what you're doing in your branch but you need to merge main otherwise this won't work. |
It is up-to-date with main. Previous commit before this one is cc7e2f8 |
I'm not near a computer but I'd do 'grep -r plugins/v5/acme' to see what's referencing this non existent path. |
@asim I am having same issue. Other ones are also missing
|
So it's a go work issue then. Fixing in a separate PR #146 |
Signed-off-by: jkoberg <[email protected]>
There still seems to be something wrong:
I tried |
Try delete and reinitialise go work |
Signed-off-by: jkoberg <[email protected]>
Seems to be even more broken after the
I think this is somehow related to the v5 update. Pipelines were green before it. Did we change build mechanics with v5? |
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
do not try to unmarshal on deletes
Adds a
Watch
method to the nats-js-kv store. This exposes the underlying natsjs watcher and allows reacting to changes in the store.