🐛 bootstrap: add support for data secret

[honza]

We can configure bootstrap by setting ConfigRef or DataSecretName. Here, we correct the logic that determines if bootstrapping is ready to allow the data secret method as well as ConfigRef.

[dtantsur]

/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main
/lgtm

[Sunnatillo]

I think we should not do logic of CABPK provider.
It is already handled here and capm3 should just read from it.

[honza]

It is already handled here and capm3 should just read from it.

This is referencing MachinePools.

The Machine reconciler doesn't have the same logic upstream. It will never set BootstrapReady if ConfigRef is empty.

[Sunnatillo]

It is already handled here and capm3 should just read from it.

This is referencing MachinePools.

The Machine reconciler doesn't have the same logic upstream. It will never set BootstrapReady if ConfigRef is empty.

My bad, in that case
/approve

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sunnatillo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Sunnatillo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tuminoid]

/retest

[tuminoid]

/retest
Come on Prow ...

[zaneb]

@Sunnatillo I think you were right that it should work that way though. I opened a bug fix upstream: kubernetes-sigs/cluster-api#11459
(Even if that merges there will be lots of broken CAPIs around for a while, so we still need this.)