Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved frontend to main repo #27

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Moved frontend to main repo #27

merged 4 commits into from
Sep 5, 2023

Conversation

shikharish
Copy link
Member

@shikharish shikharish commented Sep 4, 2023

Part of #28

@rajivharlalka
Copy link
Member

How about removing the submodule link and also moving data generation scripts in another directory to make the code clean?

Can additionally update the readme with the installation procedure for now and more things can follow later

@shikharish
Copy link
Member Author

Should I add the frontend installation process at the top of the readme?

@rajivharlalka
Copy link
Member

That should be good.

@shikharish
Copy link
Member Author

Please review.

@rajivharlalka
Copy link
Member

What do you think about moving all scripts into a different directory than the home, Would make things less cluttered

@shikharish
Copy link
Member Author

shikharish commented Sep 5, 2023

This is what I am thinking:

  • Move frontend to main repo
  • Rewrite first year scraper
  • Make the directory structure cleaner
  • Host frontend somewhere
  • Rewrite README in the same format as gyft.

@rajivharlalka
Copy link
Member

Sounds good. Can add this as an issue and make changes in different PR's that can help in reviewing and faster merging. Ig 1,3,5 are solved in this PR itself.

@shikharish
Copy link
Member Author

I think following it in order would be better.
I would restructure the directory after writing the new code and rewrite the README at the end after hosting and all.

@rajivharlalka
Copy link
Member

Cool that works too.

@rajivharlalka
Copy link
Member

May close this PR if you wish

@chirag-ghosh
Copy link
Member

Let's just handle the first task in this PR.

@chirag-ghosh chirag-ghosh mentioned this pull request Sep 5, 2023
12 tasks
@shikharish
Copy link
Member Author

Moving the frontend is done and also edited the README a bit. Merge this?
Then I will open PRs for other tasks.

@rajivharlalka
Copy link
Member

Can be merged, but this is a good case where you can try git's cherry-pick.
Try cherry-picking the commit for README changes to another branch,make another PR remove it from this. :)

@chirag-ghosh chirag-ghosh merged commit d314588 into metakgp:master Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants