-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace signup form with modal #219
Conversation
Signed-off-by: GitHub <[email protected]>
✅ Deploy Preview for meshery-play ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few suggestions:
-
Since this page is about trying out the playground, wouldn't it be better if the modal opens on clicking the big button that comes on the screen, instead of keeping the "try it out" button on top right. I mean, when I opened up the page, my first intuition was that the playground would open when I click that button, but rather, it redirected me to slack.
-
Can we also keep this discussion forum box
- The video preview image is not visible
- White colour text on yellow background I think do not go well together. Instead, can we keep the text colour as "black"?
Thank you @hargunkaur286 |
@hargunkaur286 any suggestions? |
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
fixed :-
|
Notes for Reviewers
This PR fixes #214
Signed commits