Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace signup form with modal #219

Merged
merged 12 commits into from
Oct 21, 2024
Merged

replace signup form with modal #219

merged 12 commits into from
Oct 21, 2024

Conversation

vishalvivekm
Copy link
Member

@vishalvivekm vishalvivekm commented Oct 17, 2024

Notes for Reviewers

This PR fixes #214

Signed commits

  • Yes, I signed my commits.

Signed-off-by: GitHub <[email protected]>
@vishalvivekm vishalvivekm added the pr/on hold PR/Issue on hold label Oct 17, 2024
Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for meshery-play ready!

Name Link
🔨 Latest commit 313477d
🔍 Latest deploy log https://app.netlify.com/sites/meshery-play/deploys/671652929802eb0008dec1a1
😎 Deploy Preview https://deploy-preview-219--meshery-play.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vishalvivekm vishalvivekm added the pr/do-not-merge PRs not ready to be merged label Oct 17, 2024
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
@vishalvivekm vishalvivekm removed pr/do-not-merge PRs not ready to be merged pr/on hold PR/Issue on hold labels Oct 18, 2024
@vishalvivekm vishalvivekm changed the title init replace signup form with modal Oct 18, 2024
@vishalvivekm
Copy link
Member Author

image

Copy link

@hargunkaur286 hargunkaur286 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-10-18 at 3 01 51 PM

Just a few suggestions:

  1. Since this page is about trying out the playground, wouldn't it be better if the modal opens on clicking the big button that comes on the screen, instead of keeping the "try it out" button on top right. I mean, when I opened up the page, my first intuition was that the playground would open when I click that button, but rather, it redirected me to slack.

  2. Can we also keep this discussion forum box

Screenshot 2024-10-18 at 3 06 35 PM
  1. The video preview image is not visible
Screenshot 2024-10-18 at 3 09 51 PM
  1. White colour text on yellow background I think do not go well together. Instead, can we keep the text colour as "black"?
Screenshot 2024-10-18 at 3 12 14 PM

@vishalvivekm
Copy link
Member Author

Thank you @hargunkaur286
I'll address these.

@vishalvivekm
Copy link
Member Author

@hargunkaur286
"Join the community" and Discuss calll out:
image

any suggestions?

@vishalvivekm
Copy link
Member Author

fixed :-

  1. Can we also keep this discussion forum box
  2. The video preview image is not visible
  3. White colour text on yellow background I think do not go well together. Instead, can we keep the text colour as "black"?

@vishalvivekm vishalvivekm merged commit ed03811 into master Oct 21, 2024
2 checks passed
@vishalvivekm vishalvivekm deleted the form branch October 21, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the signup form
3 participants