Central Model Registration Logic #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nithish Karthik <[email protected]>
1 task
Signed-off-by: Nithish Karthik <[email protected]>
MUzairS15
approved these changes
Aug 6, 2024
|
@humblenginr We might need to update the models API and DB functions to return all entities which are "enabled" as a default behaviour. |
|
Will you be updating the db function in this same PR? |
|
Better to track in a separate PR, I think. |
|
👍🏻 , We need to ensure that we tackle that behaviour before using the updated logic in the server, as all entities irrespective of their status will get registered. |
|
Fixes meshery/meshery#11512 |
This was referenced Aug 6, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is complementary to meshery/meshery#11385. It includes a centralised logic for registering models that mesheryctl and Meshery server can make use of.
Notes for Reviewers
Signed commits