Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model import update #539

Merged
merged 9 commits into from
Aug 8, 2024
Merged

Conversation

Jougan-0
Copy link
Contributor

@Jougan-0 Jougan-0 commented Jul 17, 2024

Description

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@Jougan-0
Copy link
Contributor Author

@MUzairS15 looked at various OCI verification one needs blob that we are not generating from export command.

Copy link
Member

@humblenginr humblenginr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can we just remove the GetById method altogether and have that feature in the Get method itself?

@Jougan-0
Copy link
Contributor Author

Jougan-0 commented Aug 8, 2024

Looks good. Can we just remove the GetById method altogether and have that feature in the Get method itself?

I tried using Get it was causing some issue we can do that in new PR.

@humblenginr
Copy link
Member

Alright

@humblenginr
Copy link
Member

Let's track that in an issue? @Jougan-0

@humblenginr humblenginr merged commit b1794be into meshery:master Aug 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants