Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing model name w/singoff #533

Merged
merged 1 commit into from
Jul 8, 2024
Merged

fix: add missing model name w/singoff #533

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions models/meshmodel/core/v1beta1/models.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,15 +127,15 @@ func (c Model) WriteModelDefinition(modelDefPath string, outputType string) erro
if err != nil {
return err
}
var modelFilePath string
if(outputType == "json"){
modelFilePath = filepath.Join(modelDefPath)
err = utils.WriteJSONToFile[Model](modelFilePath, c)
}
if(outputType == "yaml"){
modelFilePath = filepath.Join(modelDefPath)
err = utils.WriteYamlToFile[Model](modelFilePath, c)
}
var modelFilePath string
if outputType == "json" {
modelFilePath = filepath.Join(modelDefPath, "model.json")
err = utils.WriteJSONToFile[Model](modelFilePath, c)
}
if outputType == "yaml" {
modelFilePath = filepath.Join(modelDefPath, "model.yaml")
err = utils.WriteYamlToFile[Model](modelFilePath, c)
}
if err != nil {
return err
}
Expand Down
Loading