Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Schemas] Define all fields in ui:order to prevent crash #374

Merged
merged 2 commits into from
Sep 23, 2023
Merged

[Schemas] Define all fields in ui:order to prevent crash #374

merged 2 commits into from
Sep 23, 2023

Conversation

Yashsharma1911
Copy link
Contributor

Description

This PR fixes #

Recently we get * wild card issues in Meshery from RJSF form and error was You can't use multiple wild cards in ui:order even if we were using the single wild card and removing it fixes the issue in Meshery and works fine

As a result, it crashes in Meshery cloud RJSF forms and the form and error is include all field in ui:order I think this was because of different RJSF versions in both applications, though to prevent that in the future we will make sure to not use * wild card and explicitly define all fields in ui:order

FYI wild card helps us not to explicitly define ui order for all fields in form all the time, with the help of wild card we can define the order of some fields and the rest can render after that

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@Yashsharma1911
Copy link
Contributor Author

I'm testing these changes in meshery

@Yashsharma1911
Copy link
Contributor Author

it's working in both cloud and Meshery, merging it and making release

@Yashsharma1911 Yashsharma1911 merged commit ddc03e0 into meshery:master Sep 23, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant