[Schema] New help repo connection schema #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yash sharma <[email protected]>
Signed-off-by: yash sharma <[email protected]>
Signed-off-by: yash sharma <[email protected]>
leecalcote
reviewed
Sep 15, 2023
leecalcote
reviewed
Sep 15, 2023
leecalcote
reviewed
Sep 15, 2023
leecalcote
requested changes
Sep 15, 2023
| "title": "URL", | ||
| "format": "uri", | ||
| "description": "The URL of the Helm repository where the charts are hosted.", | ||
| "x-rjsf-grid-area" : "12" |
There was a problem hiding this comment.
Please include standard field validation for a URL.
|
Accepting suggested changes... |
Signed-off-by: Lee Calcote <[email protected]>
leecalcote
reviewed
Sep 18, 2023
Yashsharma1911
commented
Sep 18, 2023
| @@ -2,5 +2,5 @@ package schemas | |||
|
|
|||
| import "embed" | |||
|
|
|||
| //go:embed configuration | |||
| //go:embed configuration connections | |||
There was a problem hiding this comment.
We were using embed.FS here which adds directory files/assests directly in go binary that's why it was not able to use other directories, to use other directories we need to mention name of them here
Thankyou for making changes direclty in PR |
|
This is how directory structure will look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes meshery/meshery#8714
Added new RJSF schema for helm repo, with (name, description, a single URL)
Notes for Reviewers
Signed commits