Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Schema] Fix publish schema #357

Merged
merged 1 commit into from
Sep 1, 2023
Merged

[Schema] Fix publish schema #357

merged 1 commit into from
Sep 1, 2023

Conversation

Yashsharma1911
Copy link
Contributor

Description

This PR fixes #
Removed comma after Kubernetes in technology enum, which was causing error

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: yash sharma <[email protected]>
@Yashsharma1911
Copy link
Contributor Author

Merging this PR as this is small change

@Yashsharma1911 Yashsharma1911 merged commit ae6e13e into meshery:master Sep 1, 2023
3 checks passed
@leecalcote
Copy link
Member

Thanks for this, @Yashsharma1911 👍

@@ -7,7 +7,7 @@
"title": "Technology",
"items": {
"enum": [
"kubernetes",
"kubernetes"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RJSF crashed due to this, instead RJSF should have thrown validation issue IMO.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have that control?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants