Make the configuration of ci more simpler and fix the error #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aisuko <[email protected]>
Aisuko
force-pushed
the
fixed/wrongUseErr
branch
from
47708ed
to
b444424
Compare
|
Hey @Aisuko we also have this same issue in meshkit repo as well. it would be great if you can make that simpler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is related to #623
And I have been checked the project and I do not see the same error in issue 623. So, we can close issue #623 with this PR.
This PR replace the configuration of
golangci-lintwhich is used inmeshy-operatorproject. It is quit solid configuration. It only enables specific linters and with two enhance points of the project:And according to the latest CI configuration, I also fixed some issues like
errvariable was created by several times.And I also remove many of flags like
#nosec. It is really not helpful for maintain the project.Notes for Reviewers
Signed commits