Improve backtrace locations on error #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else | ||
| chunked_ruby << line | ||
| end | ||
| end | ||
| eval(chunked_ruby) unless chunked_ruby == '' | ||
| eval(chunked_ruby, binding, filename, line_number) unless chunked_ruby == '' |
There was a problem hiding this comment.
Does eval automatically send the caller's binding? If not it might be best to to pass nil for binding.
Also if you do file.lineno you shouldn't need to track line_number as you do above.
Before:
rake aborted!
ActiveRecord::RecordInvalid: Permission denied
(eval):5:in `edit_item'
(eval):47:in `block (3 levels) in run_file'
(eval):28:in `block (2 levels) in run_file'
/home/me/project/lib/tasks/db/reset.rake:10:in `block (3 levels) in <top (required)>'
After:
rake aborted!
ActiveRecord::RecordInvalid: Permission denied
/home/me/project/db/fixtures/development/00_foo.rb:5:in `do_something'
/home/me/project/db/fixtures/development/10_bar.rb:47:in `block (3 levels) in run_file'
/home/me/project/db/fixtures/development/10_bar.rb:28:in `block (2 levels) in run_file'
/opt/rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/seed-fu-2.3.4/lib/seed-fu/runner.rb:48:in `eval'
/opt/rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/seed-fu-2.3.4/lib/seed-fu/runner.rb:48:in `block (2 levels) in run_file'
/opt/rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/seed-fu-2.3.4/lib/seed-fu/runner.rb:60:in `block in open'
/opt/rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/seed-fu-2.3.4/lib/seed-fu/runner.rb:59:in `open'
/opt/rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/seed-fu-2.3.4/lib/seed-fu/runner.rb:59:in `open'
/opt/rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/seed-fu-2.3.4/lib/seed-fu/runner.rb:36:in `block in run_file'
/opt/rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/seed-fu-2.3.4/lib/seed-fu/runner.rb:35:in `run_file'
/opt/rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/seed-fu-2.3.4/lib/seed-fu/runner.rb:26:in `block in run'
/opt/rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/seed-fu-2.3.4/lib/seed-fu/runner.rb:25:in `each'
/opt/rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/seed-fu-2.3.4/lib/seed-fu/runner.rb:25:in `run'
/opt/rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/seed-fu-2.3.4/lib/seed-fu.rb:29:in `seed'
/opt/rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/seed-fu-2.3.4/lib/tasks/seed_fu.rake:36:in `block (2 levels) in <top (required)>'
/home/me/project/lib/tasks/db/reset_all.rake:10:in `block (3 levels) in <top (required)>'
yujinakayama
force-pushed
the
improve-eval-backtrace-location
branch
from
d949d83
to
dad425d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves backtrace locations of code executed with
eval.Before:
After: