Call eval with file and line nb so seeds fail with proper stracktraces #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcandre
force-pushed
the
mind_the_stacktrace
branch
from
0d51094
to
96519c1
Compare
marcandre
force-pushed
the
mind_the_stacktrace
branch
from
96519c1
to
1cbc3cb
Compare
|
@mbleigh please consider this. There is a very old blog post from Ola Bini (JRuby core) explaining the concept: http://ola-bini.blogspot.nl/2008/01/ruby-antipattern-using-eval-without.html |
|
There has been a commit in over a year, this project looks abandoned 😭 |
|
@aserafin This is a very simple PR, any chance of it getting merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the stacktrace starts with
.../gems/seed-fu-2.3.6/lib/seed-fu/runner.rb:46:ineval':` which is far from helpful.This also adds a basic test of the runner with a file containing
# BREAK EVAL