-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: converted Utils class in module #53
refactor: converted Utils class in module #53
Conversation
dd8f4de
to
ed078d8
Compare
7a30dbb
to
c34889e
Compare
@roccoemanuelebonanno the PR title should be updated too. While it's correctly applying the conventional commits, the changes here are not about |
Also, to make the Rubocop linter happy, we should exclude the new Utils module from the following rule:
This can be done by moving this directive from the current location to a new rule (ab sorted): Metrics/ModuleLength:
Enabled: true
Exclude:
- 'lib/itax_code/utils.rb' |
c34889e
to
92691ac
Compare
92691ac
to
5dc6150
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR 🥳
I see an error from the CodeClimate check, but it's unrelated to this PR. I'll address it in another context. |
In this PR, I have converted the Utils class into a module because, in my opinion, using a class is unnecessary in this case. "Modules are mainly used to group common functionalities and enable their reuse."