refactor!: remove Validator and merge its logic into Parser (#32)

lib/itax_code.rb

@@ -6,7 +6,6 @@
 require "itax_code/utils"
 require "itax_code/encoder"
 require "itax_code/parser"
-require "itax_code/validator"
 
 module ItaxCode
   Error = Class.new(StandardError)
@@ -42,7 +41,10 @@ def decode(tax_code)
     #
     # @return [Boolean]
     def valid?(tax_code)
-      Validator.new(tax_code).valid?
+      decode(tax_code)
+      true
+    rescue Parser::Error
+      false
     end
   end
 end

lib/itax_code/parser.rb

@@ -16,15 +16,17 @@ class Parser
     InvalidControlInternalNumberError = Class.new(Error)
     InvalidTaxCodeError               = Class.new(Error)
 
+    LENGTH = 16
+
     # @param [String] tax_code
     # @param [Utils]  utils
     def initialize(tax_code, utils = Utils.new)
       @tax_code = tax_code&.upcase
-      raise NoTaxCodeError if @tax_code.blank?
-      raise InvalidTaxCodeError unless Validator.standard_length?(@tax_code)
+      @utils    = utils
 
-      @utils = utils
-      raise InvalidControlInternalNumberError if raw[:cin] != @utils.encode_cin(tax_code)
+      raise NoTaxCodeError if @tax_code.blank?
+      raise InvalidTaxCodeError if @tax_code.length != LENGTH
+      raise InvalidControlInternalNumberError if raw[:cin] != @utils.encode_cin(@tax_code)
     end
 
     # Decodes the tax code into its components.

test/itax_code_test.rb

@@ -19,10 +19,14 @@ class ItaxCodeTest < ActiveSupport::TestCase
     assert_instance_of Hash, klass.decode("RSSMRA80A41F205B")
   end
 
-  test "#valid?" do
+  test "#valid? is truthy when the tax code can be decoded" do
     assert klass.valid?("RSSMRA80A10F205Z")
   end
 
+  test "#valid? is falsy when the parser cannot decode the given tax code" do
+    assert_not klass.valid?("WRONG")
+  end
+
   private
 
     def klass