Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split ereal.v in constructive_ereal.v and ereal.v #645

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Split ereal.v in constructive_ereal.v and ereal.v #645

merged 1 commit into from
Aug 2, 2022

Conversation

proux01
Copy link
Collaborator

@proux01 proux01 commented Apr 15, 2022

Motivation for this change

The new ereal.v file could eventually go into mathcomp-algebra once signed.v is moved there (apart from two lemmas about finmap).

Things done
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers
Automatic note to reviewers

Read this Checklist and put a milestone if possible.

@affeldt-aist affeldt-aist added this to the 0.6 milestone Apr 22, 2022
@proux01 proux01 changed the title Split ereal.v in ereal.v and classical_ereal.v Split ereal.v in constructive_ereal.v and ereal.v Jul 29, 2022
@proux01
Copy link
Collaborator Author

proux01 commented Jul 29, 2022

@affeldt-aist CI "green", this can be merged as discussed during the last meeting (the constructive_ereal.v file should further be merged with table.v from real-closed (c.f. math-comp/real-closed#29 ) and integrated into mathcomp proper).

@affeldt-aist affeldt-aist self-requested a review August 2, 2022 09:25
affeldt-aist
affeldt-aist approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@affeldt-aist affeldt-aist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very welcome step on the way to a better integration with MathComp.

@affeldt-aist affeldt-aist merged commit 89dc746 into math-comp:master Aug 2, 2022
@proux01 proux01 deleted the split_ereal branch August 2, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@affeldt-aist affeldt-aist affeldt-aist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6
Development

Successfully merging this pull request may close these issues.
2 participants
@proux01 @affeldt-aist